Hw18 parallel wrap up#5
Open
michtrofimov wants to merge 10 commits into
Open
Conversation
nvaulin
reviewed
May 21, 2024
nvaulin
left a comment
nvaulin
left a comment
There was a problem hiding this comment.
Привет!
Все здорово, мне особо нечего добавить:)
Баллы: 25/25 (RF) + 10/10 (Тесты) + 15/15 (Репозиторий и качество кода) = 50*0.5 (сдано после дедлайна) = 25
Comment on lines
+1
to
+5
| poetry.lock | ||
| __pycache__/bio_files_processor.cpython-312.pyc | ||
| __pycache__/das_biotools.cpython-312.pyc | ||
| __pycache__/test_das_biotools.cpython-312-pytest-8.2.0.pyc | ||
| __pycache__/custom_random_forest.cpython-312.pyc |
There was a problem hiding this comment.
гитигнор тоже можно добавить в гитигнор
Suggested change
| poetry.lock | |
| __pycache__/bio_files_processor.cpython-312.pyc | |
| __pycache__/das_biotools.cpython-312.pyc | |
| __pycache__/test_das_biotools.cpython-312-pytest-8.2.0.pyc | |
| __pycache__/custom_random_forest.cpython-312.pyc | |
| poetry.lock | |
| __pycache__/* | |
| .gitignore |
| feat_ids_list = [] | ||
|
|
||
| for i in range(n_estimators): | ||
| np.random.seed(self.random_state + i + (n_estimators * workers_id)) |
There was a problem hiding this comment.
Тут же i это все таки не немой счетчик
Suggested change
| np.random.seed(self.random_state + i + (n_estimators * workers_id)) | |
| np.random.seed(self.random_state + tree_id + (n_estimators * workers_id)) |
Comment on lines
+1
to
+19
| [tool.poetry] | ||
| name = "das-biotools" | ||
| version = "0.1.0" | ||
| description = "Official git repository for Das biotools" | ||
| authors = ["Michil Trofimov <trofimov.michil@gmail.com>"] | ||
| license = "MIT" | ||
| readme = "README.md" | ||
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.12" | ||
| bs4 = "^0.0.2" | ||
| pytest = "^8.2.0" | ||
| numpy = "^1.26.4" | ||
| scikit-learn = "^1.4.2" | ||
|
|
||
|
|
||
| [build-system] | ||
| requires = ["poetry-core"] | ||
| build-backend = "poetry.core.masonry.api" |
Comment on lines
+13
to
+44
| @pytest.fixture | ||
| def input_data_fasta() -> list: | ||
| """ | ||
| Fixture for input fasta data. | ||
| """ | ||
| fasta = [ | ||
| FastaRecord( | ||
| id=">GTD323452", | ||
| description="5S_rRNA NODE_272_length_223_cov_0.720238:18-129(+)", | ||
| seq="ACGGCCATAGGACTTTGAAAGCACCGCATCCCGTCCGATCTGCGAAGTTAACCAAGATGCCGCCTGGTTAGTACCATGGTGGGGGACCACATGGGAATCCCTGGTGCTGTG", | ||
| ), | ||
| FastaRecord( | ||
| id=">GTD678345", | ||
| description="16S_rRNA NODE_80_length_720_cov_1.094737:313-719(+)", | ||
| seq="TTGGCTTCTTAGAGGGACTTTTGATGTTTAATCAAAGGAAGTTTGAGGCAATAACAGGTCTGTGATGCCCTTAGATGTTCTGGGCCGCACGCGCGCTACACTGAGCCCTTGGGAGTGGTCCATTTGAGCCGGCAACGGCACGTTTGGACTGCAAACTTGGGCAAACTTGGTCATTTAGAGGAAGTAAAAGTCGTAACAAGGT", | ||
| ), | ||
| FastaRecord( | ||
| id=">GTD174893", | ||
| description="16S_rRNA NODE_1_length_2558431_cov_75.185164:2153860-2155398(+)", | ||
| seq="TTGAAGAGTTTGATCATGGCTCAGATTGAACGCTGGCGGCAGGCCTAACACATGCAAGTCGAACGGTAACAGGAAACAGCTTGCTGTTTCGCTGACGAGTGGGAAGTAGGTAGCTTAACCTTCGGGAGGGCGCTTACCACTTTGTGATTCATGACTGGGGTGAAGTCGTAACAAGGTAACCGTAGGGGAACCTGCGGTTGGATCACCTCCTT", | ||
| ), | ||
| FastaRecord( | ||
| id=">GTD906783", | ||
| description="16S_rRNA NODE_1_length_2558431_cov_75.185164:793941-795479(-)", | ||
| seq="TTGAAGAGTTTGATCATGGCTCAGATTGAACGCTGGCGGCAGGCCTAACACATGCAAGTCGAACGGTAACAGGAAACAGCTTGCTGTTTCGCTGACGAGTGGGAAGTAGGTAGCTTAACCTTCGGGAGGGCGCTTACCACTTTGTGATTCATGACTGGGGTGAAGTCGTAACAAGGTAACCGTAGGGGAACCTGCGGTTGGATCACCTCCTT", | ||
| ), | ||
| FastaRecord( | ||
| id=">GTD129563", | ||
| description="16S_rRNA NODE_4_length_428221_cov_75.638017:281055-282593(-)", | ||
| seq="CGGACGGGTGAGTAATGTCTGGGAAACTGCCTGATGGAGGGGGATAACTACTGGAAACGGTAGCTAATACCGCATAACGTCGCAAGACCAAAGAGGGGGACCGAAGTAGGTAGCTTAACCTTCGGGAGGGCGCTTACCACTTTGTGATTCATGACTGGGGTGAAGTCGTAACAAGGTAACCGTAGGGGAACCTGCGGTTGGATCACCTCCTT", | ||
| ), | ||
| ] |
There was a problem hiding this comment.
Я бы тогда это мб в какой нибудь файлик сохранил, а то многовато данных получается
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.