fix: pin accepted UniRig runtime - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The UniRig ref is consistently updated across both Dockerfiles and the lockset, and the new tests provide direct regression coverage against future pin drift.
Pull request overview
This PR pins the ComfyUI-UniRig custom node to a single accepted upstream commit across both AMD64 and ARM64 Docker images, records the same accepted ref in the repo lockset, and adds regression tests to prevent future drift between those pins.
Changes:
- Pinned UniRig install in both
Docker/DockerfileandDocker/Dockerfile.arm64to commitcab707a2c0f69900df0c8577418441750a84e0db. - Recorded the accepted UniRig repo/ref in
utils/comfy3d_lockset.json. - Added tests asserting AMD64/ARM64 Dockerfiles and the lockset all reference the same accepted UniRig commit.
File summaries
| File | Description |
|---|---|
| utils/comfy3d_lockset.json | Adds a UniRig lockset entry pointing at the accepted commit used by images. |
| tests/test_arm64_dockerfile.py | Adds regression assertions to prevent Dockerfile/lockset UniRig ref drift. |
| Docker/Dockerfile.arm64 | Updates UniRig install to the accepted UniRig commit on ARM64. |
| Docker/Dockerfile | Updates UniRig install to the accepted UniRig commit on AMD64. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cab707a2c0f69900df0c8577418441750a84e0dbcomfy3d_lockset.jsonDependencies
Verification
git diff --check: passedExact ARM64 acceptance
sha256:4355a3d28d06fe1882bee74866d1cd041c539138f819c70805ff74d081e64d13JOINTS_0,WEIGHTS_0,NORMAL,TEXCOORD_0, one skin07a5646bb839a5770e39a9f57e41c1de95631355f828144c9524463aa9ce9825/home/mg/src/remesher/downloads/comfy3d-fd002c-full-smoke/acceptance.json