Skip to content

fix: pin accepted UniRig runtime - #11

Merged
michaelgold merged 1 commit into
mainfrom
fix/unirig-aimdo-pin
Aug 31, 2026
Merged

fix: pin accepted UniRig runtime#11
michaelgold merged 1 commit into
mainfrom
fix/unirig-aimdo-pin

Conversation

@michaelgold

@michaelgold michaelgold commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • pin both AMD64 and native ARM64 images to merged UniRig commit cab707a2c0f69900df0c8577418441750a84e0db
  • record the same accepted commit in comfy3d_lockset.json
  • add regression coverage preventing AMD64/ARM64/lockset drift or restoration of stale pins

Dependencies

Verification

  • repository tests: 7 passed
  • AMD64 and ARM64 BuildKit checks: passed
  • AMD64 and ARM64 Compose validation: passed
  • lockset JSON validation and git diff --check: passed
  • independent staged-diff review: zero findings or suggestions
  • prior exact-code bind-mount smoke on ComfyUI 0.34.2 / comfy-aimdo 0.4.15 produced an 80,807-triangle textured, skinned GLB with 53 bones

Exact ARM64 acceptance

  • built image ID: sha256:4355a3d28d06fe1882bee74866d1cd041c539138f819c70805ff74d081e64d13
  • health, text-to-image, image-to-GLB, and rig-GLB: passed
  • registered node classes: 1,942; missing required classes: 0
  • source GLB: 80,894 triangles, UVs, one material, two embedded images/textures
  • rigged GLB: 80,894 triangles, JOINTS_0, WEIGHTS_0, NORMAL, TEXCOORD_0, one skin
  • Blender 5.2.1: one armature, 53 bones, one skinned mesh, 53 vertex groups
  • rigged GLB SHA-256: 07a5646bb839a5770e39a9f57e41c1de95631355f828144c9524463aa9ce9825
  • evidence: /home/mg/src/remesher/downloads/comfy3d-fd002c-full-smoke/acceptance.json

Copilot AI lite review requested due to automatic review settings August 31, 2026 12:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The UniRig ref is consistently updated across both Dockerfiles and the lockset, and the new tests provide direct regression coverage against future pin drift.

Pull request overview

This PR pins the ComfyUI-UniRig custom node to a single accepted upstream commit across both AMD64 and ARM64 Docker images, records the same accepted ref in the repo lockset, and adds regression tests to prevent future drift between those pins.

Changes:

  • Pinned UniRig install in both Docker/Dockerfile and Docker/Dockerfile.arm64 to commit cab707a2c0f69900df0c8577418441750a84e0db.
  • Recorded the accepted UniRig repo/ref in utils/comfy3d_lockset.json.
  • Added tests asserting AMD64/ARM64 Dockerfiles and the lockset all reference the same accepted UniRig commit.
File summaries
File Description
utils/comfy3d_lockset.json Adds a UniRig lockset entry pointing at the accepted commit used by images.
tests/test_arm64_dockerfile.py Adds regression assertions to prevent Dockerfile/lockset UniRig ref drift.
Docker/Dockerfile.arm64 Updates UniRig install to the accepted UniRig commit on ARM64.
Docker/Dockerfile Updates UniRig install to the accepted UniRig commit on AMD64.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@michaelgold
michaelgold merged commit 3b84d40 into main Aug 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants