refactor(live-input): rename the pipewire_bridge input mode to pipewire - #356
Open
mgth wants to merge 1 commit into
Open
refactor(live-input): rename the pipewire_bridge input mode to pipewire#356mgth wants to merge 1 commit into
mgth wants to merge 1 commit into
Conversation
With the PCM-only sink gone, the remaining PipeWire input is simply the PipeWire mode. The canonical name becomes `pipewire` on the config, the OSC control and state, and in Studio; `pipewire_bridge` and `live` stay as deserialization aliases so saved configs and older clients keep working. Internal identifiers naming the decoder bridge are unchanged: that bridge still exists and those names describe it, not the mode. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #354: with the PCM-only sink gone, the remaining PipeWire input is simply the PipeWire mode.
Change
pipewire: serderenameonInputModeandInputModeConfig, the/omniphony/control/input/modeparser, the/state/inputmode names, and Studio'snormalize_input_mode. The variants areInputMode::Pipewire/InputModeConfig::Pipewire.pipewire_bridgeandliveremain deserialization aliases, so a config saved before this change and any client still sending the old name keep working. Serialization now writespipewire; Studio's config save will rewriteinput_mode: pipewireon the next save.pipewire/ "PipeWire" (input.mode.pipewire), the summary key becomesinput.summary.pipewire, and the request flag ispipewireRequested. All eight locales updated;check-i18nreports parity.PipewireBridgeStreamConfig,run_pipewire_bridge_*, thebuild_pipewire_bridge_*pod builders) are unchanged: that bridge still exists and those names describe it, not the mode.Outside the repo
~/.config/mpv/scripts/truehd-auto-detect.lua(currently.disabled) routespipewire,pipewire_bridgeandliveto the sink alike, so it is unaffected.Verification
cargo fmt --all --check,cargo check --workspace --all-targets,cargo test --workspace(renderer);cargo checkinsrc-tauri;node --checkon the edited Studio files;npm run i18n:check;npm run lint:dead.Not in this PR
The input rows hidden in #354 (Backend, Layout, Channels, Sample rate, Map, LFE) stay hidden; deciding which return is a separate change.
🤖 Generated with Claude Code