Add optional gain reference to reconstruct (create_settings --gain_path)#23
Open
Dendooventom wants to merge 1 commit into
Open
Add optional gain reference to reconstruct (create_settings --gain_path)#23Dendooventom wants to merge 1 commit into
Dendooventom wants to merge 1 commit into
Conversation
Frame series that are not pre-gain-corrected need a gain reference. WarpTools applies this at create_settings via --gain_path (+ optional --gain_flip_x/y, --gain_transpose). This threads an optional --gain argument (and orientation switches) from the CLI through reconstruct() into the frame-series create_settings call. Default None is fully backward-compatible: no gain arguments are emitted when unset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frames that aren't pre-gain-corrected need a gain reference. WarpTools applies this at create_settings via --gain_path (+ optional --gain_flip_x/y, --gain_transpose), not at fs_motion.
This threads an optional --gain argument (plus orientation switches --gain_flip_x/--gain_flip_y/--gain_transpose) from the reconstruct CLI through reconstruct() into the frame-series create_settings call.
Fully backward-compatible: default is None, so when --gain is unset the emitted command string is unchanged.