Skip to content

Fix private key backup restore semantics#1046

Merged
mfat merged 2 commits into
feature/pluggable-secret-storage-backendsfrom
cursor/fix-backup-private-key-restore-b616
Jun 30, 2026
Merged

Fix private key backup restore semantics#1046
mfat merged 2 commits into
feature/pluggable-secret-storage-backendsfrom
cursor/fix-backup-private-key-restore-b616

Conversation

@mfat

@mfat mfat commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • Clamp restored private-key file permissions so archived group/other bits are not reapplied.
  • Keep merge-mode restore as an all-or-nothing key-pair skip: when the private key already exists, skip its public sidecar too.
  • Add regression tests for unsafe private-key modes and whole key-pair skip semantics.

Testing

  • pytest tests/test_backup_manager.py
Open in Web Open in Cursor 

cursoragent and others added 2 commits June 30, 2026 14:55
Co-authored-by: Mehdi <mfat@users.noreply.github.com>
Co-authored-by: Mehdi <mfat@users.noreply.github.com>
@mfat mfat marked this pull request as ready for review June 30, 2026 15:02
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@mfat mfat merged commit 911e82b into feature/pluggable-secret-storage-backends Jun 30, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants