Secret storage: KDBX enumeration, shared session timeout, agent UI hints#1041
Merged
mfat merged 1 commit intoJun 30, 2026
Conversation
- Add KdbxBackend.iter_credentials to enumerate the sshPilot group when unlocked - Extract shared _SessionIdleTimeout helper for Bitwarden and KeePass backends - Align SecretManager docstring and AGENTS.md with auto vs explicit semantics - Add persists_secrets() and UI hints when SSH Agent Only is selected - Hide store-password controls in password/passphrase dialogs for agent mode Co-authored-by: Mehdi <mfat@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
mfat
merged commit 7391cb4
into
feature/pluggable-secret-storage-backends
4 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up improvements to the pluggable secret storage layer based on architecture review.
Changes
KdbxBackend.iter_credentials— enumerates the dedicatedsshPilotgroup when unlocked, using thesshpilot_typecustom property (withparse_accountfallback) so credential export/orphan detection works for the KeePass backend._SessionIdleTimeout— shared sliding idle-window helper used by bothBitwardenBackendandKdbxBackend(replaces duplicated timeout code).SecretManagerclass docstring andAGENTS.mdnow describeautovs explicit selection semantics accurately (removed nonexistentauthoritativehook).SecretManager.persists_secrets()drives:Tests
test_iter_credentials_enumerates_sshpilot_grouptest_iter_credentials_empty_when_lockedtest_persists_secrets_false_for_agentAll 72 tests in
test_secret_storage.pyandtest_kdbx_backend.pypass.