Skip to content

C++ API to format model metadata#266

Merged
Luthaf merged 2 commits into
metatomic-corefrom
rmeli-cpp-format-metatada
Jun 23, 2026
Merged

C++ API to format model metadata#266
Luthaf merged 2 commits into
metatomic-corefrom
rmeli-cpp-format-metatada

Conversation

@RMeli

@RMeli RMeli commented Jun 23, 2026

Copy link
Copy Markdown
Member

@RMeli RMeli requested a review from Luthaf June 23, 2026 07:53

@Luthaf Luthaf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Luthaf

Luthaf commented Jun 23, 2026

Copy link
Copy Markdown
Member

CI failure is because ASE deprecated https://ase-lib.org/ase/md.html#ase.md.velocitydistribution.MaxwellBoltzmannDistribution in the same release they added the replacement …

Let's add this warning to the ignored ones for now.

@RMeli RMeli requested a review from Luthaf June 23, 2026 09:03
@Luthaf Luthaf merged commit 37a65b2 into metatomic-core Jun 23, 2026
68 checks passed
@Luthaf Luthaf deleted the rmeli-cpp-format-metatada branch June 23, 2026 11:22
Luthaf pushed a commit that referenced this pull request Jun 24, 2026
Luthaf pushed a commit that referenced this pull request Jun 24, 2026
Luthaf pushed a commit that referenced this pull request Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants