Refactor track ID handling#97
Open
semohr wants to merge 18 commits into
Open
Conversation
registry anyways.
- We now have a generic id class. - Tracks store ids as sets
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
@pSpitzner Just added a changelog entry and fixed the examples. Please have another look 🙃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and unifies the handling of track and playlist identifiers.
The main change is the introduction of a new
ids.pymodule, which provides standardized, immutable classes for track and playlist IDs, replacing the previous ad-hoc dictionary-based approach.The collection matching protocols and their usage are also updated to use these new ID classes, simplifying and clarifying the matching logic. Several classes and methods are updated or removed to reflect this new, unified identifier system.
TODOs: