Skip to content

Refactor track ID handling#97

Open
semohr wants to merge 18 commits into
mainfrom
track_id_refactor
Open

Refactor track ID handling#97
semohr wants to merge 18 commits into
mainfrom
track_id_refactor

Conversation

@semohr

@semohr semohr commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

This pull request refactors and unifies the handling of track and playlist identifiers.

The main change is the introduction of a new ids.py module, which provides standardized, immutable classes for track and playlist IDs, replacing the previous ad-hoc dictionary-based approach.

The collection matching protocols and their usage are also updated to use these new ID classes, simplifying and clarifying the matching logic. Several classes and methods are updated or removed to reflect this new, unified identifier system.

TODOs:

  • Test id matching/extraction for each id class
  • Changelog
  • Examples

@semohr semohr had a problem deploying to integration_tests July 5, 2026 16:15 — with GitHub Actions Failure
@semohr semohr had a problem deploying to integration_tests July 5, 2026 16:15 — with GitHub Actions Failure
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

@semohr semohr force-pushed the track_id_refactor branch from 09cabac to 15e702d Compare July 6, 2026 12:47
@semohr semohr temporarily deployed to integration_tests July 6, 2026 12:47 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests July 6, 2026 12:47 — with GitHub Actions Inactive
@semohr semohr marked this pull request as ready for review July 6, 2026 12:48
@semohr semohr requested a review from pSpitzner July 6, 2026 12:48
@semohr

semohr commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@pSpitzner Just added a changelog entry and fixed the examples. Please have another look 🙃

@semohr semohr temporarily deployed to integration_tests July 6, 2026 13:06 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests July 6, 2026 13:06 — with GitHub Actions Inactive
@semohr semohr force-pushed the track_id_refactor branch from 0f86633 to 01857b5 Compare July 6, 2026 13:11
@semohr semohr temporarily deployed to integration_tests July 6, 2026 13:11 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests July 6, 2026 13:11 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants