Format hand-maintained tests with Spotless + add CI formatting gate - #113
Merged
Conversation
Runs palantir-java-format (spotlessApply) over the custom and integration test classes so they pass spotlessJavaCheck in CI, and drops an unused import in ExpandQueryParamTest. No behavior changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adds a formatting gate to the compile job so format violations fail fast on push/PR instead of only surfacing during the publish build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
spotlessJavaCheckfailure that surfaced during publish, and adds a formatting gate to CI so it can't recur.spotlessApply/ palantir-java-format) to the hand-maintainedcustom/andintegration/test classes added in the last release, and drop an unused import inExpandQueryParamTest. No behavior changes.spotlessCheckin CI — added a Check formatting step to thecompilejob so violations fail fast on every push/PR instead of only during the publish build.Why
Spotless previously ran only as part of the publish/
assemblebuild (on tags), so a formatting violation slipped past push/PR and failed at publish time. Sincetestandpublishbothneeds: [compile], runningspotlessCheckincompilenow fails the pipeline early.Verification
./gradlew spotlessCheck→ BUILD SUCCESSFUL./gradlew compileTestJava→ BUILD SUCCESSFUL🤖 Generated with Claude Code