⚡ Bolt: Memoize Printify variant lookups to prevent N+1 API calls#74
⚡ Bolt: Memoize Printify variant lookups to prevent N+1 API calls#74merg357 wants to merge 1 commit into
Conversation
💡 What: Introduced `@functools.lru_cache(maxsize=None)` to `get_variants` functions across `printify_manager.py`, `merch_factory.py`, and `create_merch.py`. Return types were explicitly cast to immutable tuples to ensure thread safety and prevent downstream state mutations. 🎯 Why: The scripts were previously fetching static Printify variant blueprints inside iteration loops, leading to severe N+1 network request bottlenecks during bulk creation workflows. 📊 Impact: Eliminates redundant HTTP requests for previously queried `blueprint_id` and `print_provider_id` combinations. This drastically reduces overall script execution time and API rate limit pressure. 🔬 Measurement: Network calls can be verified via logging; identical blueprint queries will bypass network latency and instantly return from the local memory cache. Co-authored-by: merg357 <221854052+merg357@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Introduced
@functools.lru_cache(maxsize=None)toget_variantsfunctions acrossprintify_manager.py,merch_factory.py, andcreate_merch.py. Return types were explicitly cast to immutable tuples to ensure thread safety and prevent downstream state mutations.🎯 Why: The scripts were previously fetching static Printify variant blueprints inside iteration loops, leading to severe N+1 network request bottlenecks during bulk creation workflows.
📊 Impact: Eliminates redundant HTTP requests for previously queried
blueprint_idandprint_provider_idcombinations. This drastically reduces overall script execution time and API rate limit pressure.🔬 Measurement: Network calls can be verified via logging; identical blueprint queries will bypass network latency and instantly return from the local memory cache.
PR created automatically by Jules for task 1489989605177998800 started by @merg357