Skip to content

add backward compatibility for republish endpoints between 3.1.1 & 3.1.2 - #168

Merged
axelmarciano merged 1 commit into
mainfrom
compat/paginated-republish
Aug 19, 2026
Merged

add backward compatibility for republish endpoints between 3.1.1 & 3.1.2#168
axelmarciano merged 1 commit into
mainfrom
compat/paginated-republish

Conversation

@axelmarciano

@axelmarciano axelmarciano commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Legacy server compatibility:

  • Updated fetchUpdates in serverUpdates.ts to detect and wrap bare-array responses from pre-pagination servers into a paginated format, ensuring backward compatibility.

Testing:

  • Added a test case in serverUpdates.test.ts to verify that bare-array responses are correctly wrapped into a paginated object.

Summary by CodeRabbit

  • Bug Fixes

    • Improved compatibility with legacy server responses when retrieving updates.
    • Legacy update lists are now handled consistently with paginated responses.
  • Tests

    • Added coverage for converting legacy update lists into the standard paginated format.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a72901cf-fde8-474e-a131-8b80eb33ab37

📥 Commits

Reviewing files that changed from the base of the PR and between a47a4a6 and ebdf67b.

📒 Files selected for processing (2)
  • apps/eoas/src/lib/__tests__/serverUpdates.test.ts
  • apps/eoas/src/lib/serverUpdates.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

fetchUpdates now accepts legacy bare-array responses and converts them to paginated pages. Paginated responses remain unchanged. Tests cover the legacy response format.

Changes

Server update response compatibility

Layer / File(s) Summary
Response normalization and coverage
apps/eoas/src/lib/serverUpdates.ts, apps/eoas/src/lib/__tests__/serverUpdates.test.ts
fetchUpdates wraps legacy arrays as { items, nextCursor: null }. Tests verify the normalized response.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to ebdf6

This change adds compatibility for legacy republish responses and includes focused test coverage; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: lyric777

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: backward compatibility for republish endpoints between versions 3.1.1 and 3.1.2.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch compat/paginated-republish

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@axelmarciano
axelmarciano merged commit 1a765ea into main Aug 19, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in expo-open-ota Aug 19, 2026
@axelmarciano
axelmarciano deleted the compat/paginated-republish branch August 19, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant