Skip to content

Grab ability range from wiki#68

Open
and-zheng wants to merge 2 commits into
meraki-analytics:masterfrom
and-zheng:master
Open

Grab ability range from wiki#68
and-zheng wants to merge 2 commits into
meraki-analytics:masterfrom
and-zheng:master

Conversation

@and-zheng
Copy link
Copy Markdown

Abilities are only tracking target range right now, which directional casted abilities don't have. Added a line to grab ability range from the wiki. Consider making target range the same as cast range for directional casted abilities?

@DarkIntaqt
Copy link
Copy Markdown
Contributor

Hi, you may want to add this to the champion model file too : )

@jjmaldonis
Copy link
Copy Markdown
Member

Hey @and-zheng, can you please add the range to the Ability class as well? Without it, the code will break.

Added 'range' to the Ability class
@and-zheng
Copy link
Copy Markdown
Author

Just did, thanks for the notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants