feat: add adaptive device-first module console - #1
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
4c59a83 to
25a93f3
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25a93f3b54
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ScreenColumn( | ||
| modifier = Modifier | ||
| .verticalScroll(rememberScrollState()) | ||
| .windowInsetsPadding(WindowInsets.safeDrawing.only(WindowInsetsSides.Top)), |
There was a problem hiding this comment.
When the initial model-setup flow is displayed on a device using three-button navigation, the newly enabled edge-to-edge mode lets content extend beneath the navigation bar, but this screen applies only the top safe-drawing inset and is rendered outside NavigationSuiteScaffold. At maximum scroll, the 32 dp generic bottom padding is smaller than common navigation-bar insets, so the final explanatory content can remain obscured; include the bottom safe-drawing inset on this standalone screen.
Useful? React with 👍 / 👎.
1 participant
Summary
android-module-host.mdthe source of truth for current Android candidate evidence.Verification
pnpm check— 91 Vitest tests, 3 verification-script tests, lint, typecheck, and production builds.pnpm --filter @opendevice/desktop test:e2e— 1 Playwright workflow passed.pnpm --filter @opendevice/site test:e2e— 2 responsive/release-honesty workflows passed.cargo test --manifest-path apps/desktop/src-tauri/Cargo.toml --locked— 18 tests passed.cargo clippy --manifest-path apps/desktop/src-tauri/Cargo.toml --locked --all-targets -- -D warnings.:app:testDebugUnitTest :app:lintDebug :app:assembleDebug :app:assembleDebugAndroidTest— build successful.Release boundaries
This PR publishes source for review only. It does not create a tag or Release, deploy the product site, add production signing/notarization, enable online module acquisition, or publish a public gateway. Current phone evidence remains version-bound to the hashes recorded in the verification documents.