[RUN-5058] Document the Java tracing API (11.10.0)#10964
Open
atennapel wants to merge 2 commits intomendix:developmentfrom
Open
[RUN-5058] Document the Java tracing API (11.10.0)#10964atennapel wants to merge 2 commits intomendix:developmentfrom
atennapel wants to merge 2 commits intomendix:developmentfrom
Conversation
Contributor
|
Approved by Runtime Team |
Collaborator
MarkvanMents
left a comment
MarkvanMents
left a comment
There was a problem hiding this comment.
Looks good and clear. I just have one observation - let me know if it needs a change or whether the placeholders are good.
Comment on lines
+181
to
+182
| .createSpan("my span name") | ||
| .withAttribute("attribute key", "attribute value") |
Collaborator
There was a problem hiding this comment.
Do these placeholder values ("my span name" etc.) take spaces?
If not, might be better to have my_span_name or mySpanName as placeholders?
Contributor
Author
There was a problem hiding this comment.
The span name can take spaces and in production we already have span names with spaces.
The attributes keys can also take spaces, though in production we have no attribute keys that have spaces, so it might be good to only update the attribute key to attribute_key.
MarkvanMents
added
Needs R&D technical verification
and removed
Needs language review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR is for a feature introduces in Mx 11.10.0.