Committing a Rolled-Back Object#10899
Merged
MarkvanMents merged 15 commits intodevelopmentfrom Apr 21, 2026
Merged
Conversation
basdebakker
reviewed
Mar 20, 2026
basdebakker
reviewed
Mar 20, 2026
basdebakker
reviewed
Mar 20, 2026
basdebakker
reviewed
Mar 20, 2026
basdebakker
reviewed
Mar 20, 2026
basdebakker
reviewed
Mar 20, 2026
MarkvanMents
commented
Mar 23, 2026
Collaborator
Author
MarkvanMents
left a comment
MarkvanMents
left a comment
There was a problem hiding this comment.
Thanks for all the comments @basdebakker
I've tried to address them in 89a5f33 - please let me know if it needs more clarification.
MarkvanMents
commented
Mar 23, 2026
Collaborator
Author
MarkvanMents
left a comment
MarkvanMents
left a comment
There was a problem hiding this comment.
Thanks for the comprehensive review.
Resolved some of these (I hope) - there are still two discussions outstanding where I'm not sure what best to say.
Can you have another look and see if there are still changes I need to make.
Thanks for all your work so far.
…mation about the existing error.
MarkvanMents
commented
Mar 31, 2026
Collaborator
Author
MarkvanMents
left a comment
MarkvanMents
left a comment
There was a problem hiding this comment.
Hi @basdebakker and @lvanengelen-mx
I've tried to clarify things after my discussion with Leroy in these commits: https://github.com/mendix/docs/pull/10899/changes/23debd16bc93f77be2831a1c26d06c541ac3cd31..6aba2b817fcc7015908d2dc90198d8eff665aaae
I also have one outstanding question where I am not sure which statement is more accurate.
I hope these changes take us towards more clarity. Please let me know what you think.
Mark
MarkvanMents
commented
Apr 13, 2026
Collaborator
Author
MarkvanMents
left a comment
MarkvanMents
left a comment
There was a problem hiding this comment.
Responded to error-events.md and error-handling-in-microflows.md
Please let me know if suggestions are good.
Will look at committing-objects.md in separate review.
MarkvanMents
commented
Apr 13, 2026
Collaborator
Author
MarkvanMents
left a comment
MarkvanMents
left a comment
There was a problem hiding this comment.
@lvanengelen-mx
Thanks for the comprehensive review.
I've made some more suggestions in response to your review. Please let me know if you have any further points.
I've now responded to everything, I think. If nothing is too misleading, I'd like to publish what we have (as it is an improvement to what is already out there). We can always come back to this at a later date (I'm sure we will).
Co-authored-by: Mark van Ments <35492184+MarkvanMents@users.noreply.github.com>
MarkvanMents
commented
Apr 21, 2026
Collaborator
Author
MarkvanMents
left a comment
MarkvanMents
left a comment
There was a problem hiding this comment.
Discussion with Leroy
MarkvanMents
commented
Apr 21, 2026
Co-authored-by: Mark van Ments <35492184+MarkvanMents@users.noreply.github.com>
Collaborator
Author
|
Agreed to publish after discussion with Leroy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.