Skip to content

docs: Building with demo and commercial together#2841

Open
rewanrashid-boop wants to merge 1 commit into
mendersoftware:masterfrom
rewanrashid-boop:docs/demo-and-commercial-layers
Open

docs: Building with demo and commercial together#2841
rewanrashid-boop wants to merge 1 commit into
mendersoftware:masterfrom
rewanrashid-boop:docs/demo-and-commercial-layers

Conversation

@rewanrashid-boop

Copy link
Copy Markdown
Contributor

Updated the docs with solution to problem regarding custom mender-gateway.conf in builds with both commercial and demo layers.

Ticket: MEN-6625

Updated the docs with solution to problem regarding
custom mender-gateway.conf in builds with both commercial and demo
layers.

Ticket: MEN-6625
Signed-off-by: Rewan Rashid <rewan.rashid@northern.tech>
@rewanrashid-boop

Copy link
Copy Markdown
Contributor Author

In this task (MEN-6625) the issue really only appears when commercial and demo layer are used together which as i understand only for testing. It happens because the .bbappend in demo's mender-gateway grabs custom files under the name mender-gateway.conf into doc. Therefore i think doing any code change is not really necessary and rather it is better to just update the docs for this case.

@vpodzime vpodzime left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but I'm no yocto expert to dare approving this 😊

@danielskinstad

Copy link
Copy Markdown
Contributor

In this task (MEN-6625) the issue really only appears when commercial and demo layer are used together which as i understand only for testing. It happens because the .bbappend in demo's mender-gateway grabs custom files under the name mender-gateway.conf into doc. Therefore i think doing any code change is not really necessary and rather it is better to just update the docs for this case.

IMO this sounds like weird behavior. Any reason why you don't think we should try to address this in the code instead?

@rewanrashid-boop

Copy link
Copy Markdown
Contributor Author

Yeah that's really what I'm kinda wondering is do still need this thing for examples confs does it have any other purpose so that it would be bad to just remove it. If it is not needed then i can just close this PR open a new one on meta-mender with the line removed if no one has any objections. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants