Fix Clippy warning and stale APT package lists - #1500
Merged
Conversation
thedataking
force-pushed
the
perl/harden-apt-ci
branch
from
August 14, 2026 08:40
ee466ff to
532a2c7
Compare
thedataking
marked this pull request as ready for review
August 14, 2026 08:42
Closed
`use_ref` already expresses whether `refidx` should be present, so construct the `Option` from that boolean instead of creating `Some` and filtering it afterward. This is equivalent while satisfying Clippy's more direct idiom.
thedataking
force-pushed
the
perl/harden-apt-ci
branch
from
August 14, 2026 08:47
532a2c7 to
9e75520
Compare
thedataking
changed the title
bdaehlie
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was blocked by two independent failures: Clippy rejected the indirect
Some(...).filter(...)construction for an optional reference index, while GitHub’s Ubuntu image advertised glibc packages that had already disappeared from its mirrors, allowing the APT cache action to preserve an incomplete installation withoutnasm. Construct the option withbool::then_some, refresh APT metadata before installing the x86 prerequisites, and advance the cache generation so the invalid entry cannot be reused.