bug/bookmark-list-category-hierarchy#34
Conversation
…n in `get-mlh.sh`. - Update `mlh-docker.sh` to handle `sudo` usage by adding Docker binary resolution logic. - Enhance `README.md` with a note on using `sudo` for Docker commands.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cleanup_unnecessary_files() { | ||
| green "Cleaning up unnecessary files…" | ||
|
|
||
| # List of files/directories to remove (user doesn't need these) | ||
| local cleanup_items=( | ||
| "tests" | ||
| "CLAUDE.md" | ||
| "docs/BOOKMARK_ALIAS_GUIDE.md" | ||
| "docs/BOOKMARK_QUICK_REFERENCE.md" | ||
| "docs/RELEASE_NOTES_v1.5.0.md" | ||
| "docs/RELEASE_NOTES_v1.5.1.md" | ||
| "docs/assets" | ||
| ".git" | ||
| ".github" | ||
| "TODO.md" | ||
| ".gitignore" | ||
| ) |
There was a problem hiding this comment.
The new cleanup routine removes the .git directory after cloning. download_repo relies on the presence of .git to decide between git pull and git clone; when the directory is deleted, rerunning get-mlh.sh will hit the git clone path even though ${INSTALL_DIR} already exists, causing fatal: destination path ... already exists and is not an empty directory and preventing updates. Users who reinstall will have to manually remove the install directory to recover. Consider keeping .git or adjusting the download logic to handle a non‑git install.
Useful? React with 👍 / 👎.
…xible Docker command checks - Added fallback logic to set `ROOT_DIR` based on script location if not pre-set. - Enhanced test patterns to accept both direct Docker commands and variable-based equivalents (`DOCKER_CMD`).
…matting in `get-mlh.sh`
…rsion.sh` - Introduced `uninstall` option in the menu interface of `mlh.sh`. - Added `uninstall_mlh` function in `mlh-version.sh` for comprehensive cleanup: - Removes symlinks, configuration files, and PATH updates from `.bashrc` and `.profile`. - Ensures manual removal or confirmation where necessary. - Updated installation script to include comments for better file cleanup logic. - Improved menu option handling for seamless uninstall integration.
1 participant
No description provided.