Skip to content

Use Base.lcm instead of kgv#60

Merged
meggart merged 1 commit intomainfrom
fc/remove_kgv
Apr 27, 2026
Merged

Use Base.lcm instead of kgv#60
meggart merged 1 commit intomainfrom
fc/remove_kgv

Conversation

@felixcremer
Copy link
Copy Markdown
Collaborator

This removes our internal least common multiple implementation with the Base functionality.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.75%. Comparing base (7761aec) to head (130a3ef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   45.85%   45.75%   -0.11%     
==========================================
  Files          23       23              
  Lines        2137     2133       -4     
==========================================
- Hits          980      976       -4     
  Misses       1157     1157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 27, 2026

Coverage Report for CI Build 24986291123

Coverage decreased (-0.1%) to 45.757%

Details

  • Coverage decreased (-0.1%) from the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 2133
Covered Lines: 976
Line Coverage: 45.76%
Coverage Strength: 29.11 hits per line

💛 - Coveralls

@meggart meggart merged commit 3fae4e3 into main Apr 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants