use rate-limiter for better default behavior#119
Merged
Conversation
also linting from something
philbudne
approved these changes
May 4, 2026
Contributor
|
Just checking: do you have pre-commit the hook installed? |
Contributor
Author
|
Yes. It ran some stuff that changed the code via some set of linting rules before it would let me commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very small change to use a rate limiter for better behavior by default. People (and us) can always override
client. RATE_LIMIT_PER_MINUTEvalue to speed things up. Defaults to 2/second, which is the default in server code for standard users.I suppose we could make a call to
profileendpoint and set this value at client instantiation time to better reflect membership inGROUPS.HIGH_RATE_LIMIToradminstatus but that feels a little "too clever" at first glance to me.