Skip to content

[shadowmap] docs: simplify README onboarding#32

Open
mdabir1203 wants to merge 2 commits into
mainfrom
codex/improve-readme-for-professionalism-m3atuu
Open

[shadowmap] docs: simplify README onboarding#32
mdabir1203 wants to merge 2 commits into
mainfrom
codex/improve-readme-for-professionalism-m3atuu

Conversation

@mdabir1203

Copy link
Copy Markdown
Owner

Summary

  • tighten the README introduction and feature summary to highlight ShadowMap's multi-cloud value without overwhelming newcomers
  • replace lengthy provider and usage sections with an accessible coverage table plus step-by-step onboarding that requires no coding experience
  • keep only the highest-impact guidance by focusing on GPT-4 reporting, sample exports, roadmap highlights, and responsible-use reminders

Testing

  • cargo fmt --all
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace

https://chatgpt.com/codex/tasks/task_e_68d40fdb6a4c83269c7609aaee9d155d

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment thread README.md
Comment on lines 47 to +53
```bash
cargo clippy -- -D warnings
./target/release/shadowmap \
--domain example.com \
--providers aws,azure,gcp \
--report markdown

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Remove unsupported flags from quick-start command

The new onboarding example uses --providers and --report, but the CLI only accepts domain, concurrency, timeout, and retries. Running the command as written fails immediately (error: unexpected argument '--providers' found). This will block newcomers following the README, so the example should be updated to use the actual flags exposed by Args.

Useful? React with 👍 / 👎.

Comment thread README.md
Comment on lines 64 to +66
```bash
shadowmap -d target.com --json > report.json
export OPENAI_API_KEY="sk-..."
./target/release/shadowmap --domain example.com --providers aws,azure,gcp --report markdown --gpt4 --poc

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Remove nonexistent GPT-4 options from documentation

The GPT-4 reporting section instructs users to run --gpt4 --poc, but those flags are not defined anywhere in the crate (no gpt references in src/). Executing the example fails with error: unexpected argument '--gpt4' found, so the docs currently advertise a feature the binary cannot perform.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant