Fall back to launch dir when resolving project root outside git#13
Merged
Conversation
- git rev-parse failure in non-git folders no longer aborts the hook - Falls back to CLAUDE_PROJECT_DIR, then $PWD, so memories index correctly - Git-repo resolution (toplevel anchor) is unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The sync-memories hook resolved the project root exclusively through
git rev-parse --show-topleveland bailed silently (|| exit 0) when it failed. In a non-git folder this meant memories were never indexed, with no visible error.PR #11 fixed this same bug but was reverted in #12 for bundling too much unrelated hardening (diagnostic logging, doc-count verification, embedding env var, scrape/refresh rework) into one change. This PR extracts just the non-git fallback, nothing else.
Change
hooks/sync-memories.sh: whengit rev-parseyields nothing, fall back toCLAUDE_PROJECT_DIR, then$PWD. Git-repo resolution (anchoring to the toplevel) is unchanged.Test plan
bash -nsyntax check.claude/memories/*.md, ran the hook directly — it resolvedproject_rootto the scratch dir, indexed it into docs-mcp-server (confirmed vialist), and wrote.memories-last-indexed.claude/memories— hook exits 0, no side effects