Replace non-reentrant localtime with localtime_r in databaseConnection.cpp

[Copilot]

std::localtime uses a shared internal buffer, making it unsafe in multi-threaded contexts. Replaced with the reentrant localtime_r, which writes into a caller-supplied struct tm.

Changes

• source/databaseConnection.cpp
  • Swap std::localtime → localtime_r with a stack-allocated, zero-initialized struct tm
  • Guard against localtime_r returning nullptr (invalid time conversion), logging an error and skipping the entry

// Before
auto tm = *std::localtime(&time_t);

// After
struct tm tm = {};
if (localtime_r(&time_t, &tm) == nullptr) {
    std::cerr << "Error: failed to convert timestamp" << std::endl;
    continue;
}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

This PR updates DatabaseConnection::printResults to avoid the non-reentrant std::localtime by switching to a reentrant local-time conversion function and handling conversion failures.

Changes:

• Replace std::localtime usage with localtime_r and a caller-provided tm buffer.
• Add a failure guard for timestamp conversion that logs an error and skips the affected entry.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

localtime_r is a POSIX API and is not available under MSVC/Windows builds. Since the project’s CMakeLists explicitly supports MSVC, this change can break Windows compilation. Consider adding a small platform abstraction (e.g., #if defined(_WIN32) use localtime_s(&tm, &time_t); otherwise localtime_r) and qualifying the call (::localtime_r) with the appropriate <ctime>/<time.h> include so the declaration is guaranteed to be visible.

[Copilot]

This change introduces a new failure branch (localtime_r(...) == nullptr) that alters output behavior (skips entries). The repository has XCTest coverage for DatabaseConnection (e.g., tests/db.mm), but there’s no test exercising printResults timestamp formatting or the new error path. Consider extracting the timestamp-to-string formatting into a helper that can be unit tested (including the failure case) without relying on stdout/stderr capture.