fix(tooling): protect asset files from editorconfig normalization#8
Merged
Conversation
The trim/newline exception covered only the four vendored directories; root-level hashed assets (favicon.<hash>.svg verifiably lacks a final newline) were left exposed to editor-side normalization that would break their content hashes. Disable both fixers for png/webp/svg/ico/woff2 everywhere. The pre-commit gate already protected these at commit time, so this closes the editor-side half only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the editor-side half of a review finding from #6: the .editorconfig trim/newline exception covered only the four vendored directories, leaving root-level hashed assets (favicon..svg verifiably lacks a final newline) exposed to editor-save normalization that would break their content hashes.
Changes
Testing