chart: more configurable values and rolling restart on config change - #20
Open
akukhar wants to merge 1 commit into
Open
chart: more configurable values and rolling restart on config change#20akukhar wants to merge 1 commit into
akukhar wants to merge 1 commit into
Conversation
Four small chart fixes and features. Chart bumped 0.1.0 -> 0.2.0. * Probes driven from values.yaml. templates/deployment.yaml rendered both a values-driven probe block and a hardcoded second pair; the hardcoded one won, so `--set livenessProbe.*` was silently ignored. Hardcoded block removed; values.yaml now carries the full probe spec. The container port is named `https` so `port: https` resolves. * .Values.resources consumed. Previously declared in values.yaml but never referenced from deployment.yaml. Wiring it in also gives HPA's CPU/memory thresholds a real baseline. * Configurable webhook failurePolicy. New `WebhookFailurePolicy`, default `Fail`. * Rolling restart on registry config change. cmd/config.go reads /etc/ecr-pull-through/registries.yaml once at startup, so changes via `helm upgrade` never reached running pods. A new `ecr-pull-through.registriesYaml` named template feeds both configmap.yaml and a `checksum/config` annotation on the Deployment; the annotation flips when `awsRegion`, `awsAccountId`, or `registries` change. Rendered `awsRegion` / `awsAccountId` are quoted, so a leading-zero AWS account ID doesn't get misread as a number.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small chart fixes and features. Chart bumped 0.1.0 -> 0.2.0.
Probes driven from
values.yamltemplates/deployment.yamlrendered both a values-driven probe block and a hardcoded second pair; the hardcoded one won, so--set livenessProbe.*was silently ignored. Hardcoded block removed;values.yamlnow carries the full probe spec. The container port is namedhttpssoport: httpsresolves..Values.resourcesconsumedPreviously declared in
values.yamlbut never referenced fromdeployment.yaml. Wiring it in also gives HPA's CPU/memory thresholds a real baseline.Configurable webhook
failurePolicyNew
WebhookFailurePolicy, defaultFail.Rolling restart on registry config change
cmd/config.goreads/etc/ecr-pull-through/registries.yamlonce at startup, so changes viahelm upgradenever reached running pods. A newecr-pull-through.registriesYamlnamed template feeds bothconfigmap.yamland achecksum/configannotation on the Deployment; the annotation flips whenawsRegion,awsAccountId, orregistrieschange.awsRegion/awsAccountIdare also rendered quoted, so a leading-zero AWS account ID doesn't get misread as a number.