Skip to content
This repository was archived by the owner on Jan 25, 2026. It is now read-only.

mark anomalous metrics as such - #7

Open
zmarcantel wants to merge 1 commit into
mattrco:masterfrom
zmarcantel:master
Open

mark anomalous metrics as such#7
zmarcantel wants to merge 1 commit into
mattrco:masterfrom
zmarcantel:master

Conversation

@zmarcantel

Copy link
Copy Markdown

I added a bool field to the data.Datapoint struct that will say "yes, I am an anomaly".

This helps applications parse the output channel without creating a second channel that could potentially block if not properly/diligently read from. It also avoids a less-than-ideal strings.HasSuffix("anomalous") check.

I'm open to discussing other methods, but this seemed the easiest.

@mattrco

mattrco commented Jul 22, 2014

Copy link
Copy Markdown
Owner

Thanks for this. At the moment the three sigma analyzer has a separate output channel for anomalous values; is this insufficient for the use case you're thinking of?

I'm not opposed to merging this, just want to understand the use case better.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants