This repository was archived by the owner on Jan 25, 2026. It is now read-only.
mark anomalous metrics as such - #7
Open
zmarcantel wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for this. At the moment the three sigma analyzer has a separate output channel for anomalous values; is this insufficient for the use case you're thinking of? I'm not opposed to merging this, just want to understand the use case better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a
boolfield to thedata.Datapointstruct that will say "yes, I am an anomaly".This helps applications parse the output channel without creating a second channel that could potentially block if not properly/diligently read from. It also avoids a less-than-ideal
strings.HasSuffix("anomalous")check.I'm open to discussing other methods, but this seemed the easiest.