Add docs for experimental mobile watermarking (v11.7)#8954
Conversation
* Update generate_changelog.py * Update generate_changelog.py
Documents the new Enterprise, experimental "Enable Mobile Watermark" setting introduced by mattermost/mattermost#36025 and the visible mobile watermark overlay introduced by mattermost/mattermost-mobile#9682: - experimental-configuration-settings.rst: new "Enable Mobile Watermark" entry (Experimental > Features, disabled by default, Enterprise-only, v11.7 onward). - deployment-guide/mobile/mobile-security-features.rst: deep-dive "Mobile watermarking" section describing the username/domain/date/time overlay and its DLP-attribution purpose. - security-guide/mobile-security.rst: short overview section linking to the deep-dive and to the experimental config setting. Refs issue #8953. Co-authored-by: Combs7th <Combs7th@users.noreply.github.com>
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis pull request adds documentation for a new experimental mobile watermarking feature across three guides. The changes describe how administrators enable the feature, what authenticated mobile users will observe, and its role in data loss prevention workflows. All additions reference configuration, version availability (v11.7+), and the visual-only, non-blocking nature of the overlay. ChangesMobile Watermarking Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@source/deployment-guide/mobile/mobile-security-features.rst`:
- Around line 59-69: Update the "Mobile watermarking" paragraph to explicitly
state the enterprise plan requirement: indicate that the feature is available
from Mattermost v11.7 onward and is restricted to Enterprise / Enterprise
Advanced deployments (add wording like "Enterprise or Enterprise Advanced only")
so self-hosted non-Enterprise admins are not misled; also mirror the phrasing
used on admin/security pages and ensure the :ref:`Enable Mobile Watermark
<administration-guide/configure/experimental-configuration-settings:enable
mobile watermark>` reference remains intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 645add29-2f83-4240-bccd-cdee90a32cba
📒 Files selected for processing (3)
source/administration-guide/configure/experimental-configuration-settings.rstsource/deployment-guide/mobile/mobile-security-features.rstsource/security-guide/mobile-security.rst
|
Newest code from mattermost has been published to preview environment for Git SHA 2602efb |
|
@claude - Please implement coderabbitai's feedback above. |
|
Claude finished @Combs7th's task in 50s —— View job Implemented CodeRabbit's feedback
Change summaryUpdated -Mobile watermarking is an experimental capability available from Mattermost v11.7 onward that helps organizations…
+Mobile watermarking is an experimental Enterprise capability, available on `Enterprise and Enterprise Advanced plans <https://mattermost.com/pricing/>`__ from Mattermost v11.7 onward, that helps organizations…This matches the |
Address CodeRabbit review: explicitly state Enterprise and Enterprise Advanced plan availability in the deployment-guide mobile watermarking section to mirror the admin and security pages and avoid misleading self-hosted, non-Enterprise admins. Co-authored-by: Combs7th <Combs7th@users.noreply.github.com>
|
Newest code from mattermost has been published to preview environment for Git SHA 87040f2 |
Combs7th
added
1: Dev Review
|
Newest code from mattermost has been published to preview environment for Git SHA 57868fc |
|
Heya @asaadmahmood: I have a first draft ready for the mobile watermarking docs. One thing I want to verify before this goes too far: the server PR appears to use I also flagged a few quick review points in the PR:
Once those are confirmed, I think the draft should be in pretty good shape unless there's anything else you think we should add. |
|
Newest code from mattermost has been published to preview environment for Git SHA 20a8b99 |
|
Newest code from mattermost has been published to preview environment for Git SHA a678d63 |
|
Newest code from mattermost has been published to preview environment for Git SHA 9f28b95 |
2 participants
Documents the new Enterprise, experimental “Enable Mobile Watermark” setting introduced by mattermost/mattermost#36025 and the visible mobile watermark overlay introduced by mattermost/mattermost-mobile#9682.
Pages edited
Closes #8953.
Generated with Claude Code