M1.4: remove legacy deploy.yml — staging is the single main-push deploy - #2
Merged
Conversation
Legacy GCP_SA_KEY-based workflow duplicated deploy-staging.yml on every main push, targeted a third service name (atelier), and consumed secrets not in the provisioning list. Removed; STATE.md updated.
Second commit on this branch: strips the M2 invite-flow files that were swept into the first commit by a broad git add, leaving only the workflow removal + STATE.md notes. PR diff = deploy.yml deletion + STATE.md edits.
Commit 90f91e0 intended to strip only M2 invite-flow files, but the broad git add also deleted core app files (prisma/schema.prisma, auth, middleware, cart/checkout/orders/commissions routes, e2e seed). Restore them from main so the PR scope is exactly the stated intent: deploy.yml removal + GOAL.md/STATE.md docs updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M1.4 — Remove legacy deploy.yml
What
Deleted
.github/workflows/deploy.yml— the legacy GCP_SA_KEY-based deploy workflow.Why
deploy-staging.yml, and deployed to a third service name (atelier) — so a push to main would fire two deploy workflows targeting different Cloud Run services with no clear owner.secrets.GCP_SA_KEY(long-lived service-account key) instead of Workload Identity Federation (vars.GCP_WIP/GCP_SA) used by staging and prod.DATABASE_URL,AUTH_SECRET,STRIPE_SECRET_KEY) instead of Secret Manager references.GCP_PROJECT_ID,GCP_SA_KEY,DATABASE_URL, …) are not part of the provisioning list indocs/P1.3-provisioning.md, so it would fail at auth on the first main push anyway.After this change, deploy responsibilities are unambiguous:
ci.yml— lint/type/build/unit/e2e on every PR + maindeploy-staging.yml— the single auto-deploy on main push (Cloud Runatelier-staging, 0% → health gate → 100%)deploy-prod.yml— taggedv*releases with environment approval gate (Cloud Runatelier-prod, gradual shift)How tested
No runtime code touched — workflow removal only.
STATE.mdupdated to reflect the removal. CI (lint/type/build/tests) is unaffected and runs on this PR.