Ensure checking RoomIDs works for room version 12#467
Merged
kegsay merged 4 commits intoJul 16, 2026
Conversation
… be opaque strings
1 task
Contributor
Author
|
Actually, you know what? This is used in a couple different places for other sigil checks. Let me re-evaluate. I was to hasty. |
To be fair, "user" is only featured once while "room" is far more prevelant
Contributor
Author
There, that is more inclusive of uses other |
kegsay
reviewed
Jul 2, 2026
…se the RoomID instead
RoomIDs works for room version 12
kegsay
approved these changes
Jul 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
==========================================
- Coverage 53.90% 53.81% -0.10%
==========================================
Files 52 52
Lines 6025 6026 +1
==========================================
- Hits 3248 3243 -5
- Misses 2363 2368 +5
- Partials 414 415 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Signed-off-by:
Jason Little <j.little@famedly.com>