Skip to content

Ensure checking RoomIDs works for room version 12#467

Merged
kegsay merged 4 commits into
matrix-org:mainfrom
jason-famedly:jl/remove-domain-check-on-roomid
Jul 16, 2026
Merged

Ensure checking RoomIDs works for room version 12#467
kegsay merged 4 commits into
matrix-org:mainfrom
jason-famedly:jl/remove-domain-check-on-roomid

Conversation

@jason-famedly

@jason-famedly jason-famedly commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Pull Request Checklist

Signed-off-by: Jason Little <j.little@famedly.com>

@jason-famedly

Copy link
Copy Markdown
Contributor Author

Actually, you know what? This is used in a couple different places for other sigil checks. Let me re-evaluate. I was to hasty.

To be fair, "user" is only featured once while "room" is far more
prevelant
@jason-famedly

Copy link
Copy Markdown
Contributor Author

Actually, you know what? This is used in a couple different places for other sigil checks. Let me re-evaluate. I was to hasty.

There, that is more inclusive of uses other kind == room. It probably would have been fine, but this is probably better

Comment thread event.go Outdated
@jason-famedly
jason-famedly requested a review from kegsay July 16, 2026 10:53
@jason-famedly jason-famedly changed the title Remove check on Room IDs having a domain component Ensure checking RoomIDs works for room version 12 Jul 16, 2026
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.81%. Comparing base (c9c4687) to head (b674263).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
- Coverage   53.90%   53.81%   -0.10%     
==========================================
  Files          52       52              
  Lines        6025     6026       +1     
==========================================
- Hits         3248     3243       -5     
- Misses       2363     2368       +5     
- Partials      414      415       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kegsay
kegsay merged commit 4fe595d into matrix-org:main Jul 16, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants