Skip to content

Ignore error for send B before A in TestUnrejectRejectedEvents test#809

Merged
reivilibre merged 1 commit into
matrix-org:mainfrom
palpo-matrix-server:reject
Oct 9, 2025
Merged

Ignore error for send B before A in TestUnrejectRejectedEvents test#809
reivilibre merged 1 commit into
matrix-org:mainfrom
palpo-matrix-server:reject

Conversation

@chrislearn

@chrislearn chrislearn commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

When sending event B to the federation server for the first time, since previous event A is missing, it's reasonable for the server to return an error.

Synapse doesn't seem to return errors, but there are comments like this:

synapse/federation/federation_server.py#L1312-L1314

# XXX: Ideally, we'd inform the remote that we failed to process
# the event, but we can't return an error in the transaction
# response (as we've already responded).

Signed-off-by: Chrislearn Young chris@acroidea.com

Pull Request Checklist

@chrislearn
chrislearn requested review from a team as code owners October 9, 2025 13:22

@reivilibre reivilibre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. (MustSendTransaction does indeed check that events are not rejected, yet the comment says it should be rejected)

@reivilibre
reivilibre merged commit 3752f0c into matrix-org:main Oct 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants