Skip to content

Create library and pipeline for gateway verification - #2

Open
aakano684 wants to merge 5 commits into
developfrom
ft1
Open

Create library and pipeline for gateway verification#2
aakano684 wants to merge 5 commits into
developfrom
ft1

Conversation

@aakano684

Copy link
Copy Markdown
Contributor

Purpose

  • Create Library and pipeline for gateway verification

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@aakano684
aakano684 requested a review from noce2 December 23, 2020 00:42
@aakano684 aakano684 changed the title Create Library and pipeline for gateway verification Create library and pipeline for gateway verification Dec 23, 2020
Comment thread README.md
@@ -1,2 +1,2 @@
# api-gateway-verification

@noce2 noce2 Dec 27, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could we change the name of the repository? The current name it has doesn't match the library's intent (it's for http request signature verification in general and so could be reused by our components if the need arose) as well as by someone else who might want to use the same technique.

@noce2 noce2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 questions, nothing particularly major.

Comment thread README.md
@@ -1,2 +1,2 @@
# api-gateway-verification
Shared library to verify
library for api gateway verification

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could we add some notes on how the library should be used? First from how does this dependency get added into your pom.xml and second from where does it get included in my code.



@ExtendWith(SpringExtension.class)
public class HTTPRequestSignatureVerificationEnabledHandlerTest {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did we have to change to the implementation class in bringing it here? As the handler isn't here I can't easily tell.


on:
push:
branches: [ master, develop , ft* ]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On reflection I think we probably want to save minutes and not build feature branches by default? I assume GitHub workflows have similar restrictions to Azure DevOps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants