Conversation
| @@ -1,2 +1,2 @@ | |||
| # api-gateway-verification | |||
There was a problem hiding this comment.
Please could we change the name of the repository? The current name it has doesn't match the library's intent (it's for http request signature verification in general and so could be reused by our components if the need arose) as well as by someone else who might want to use the same technique.
noce2
left a comment
There was a problem hiding this comment.
2 questions, nothing particularly major.
| @@ -1,2 +1,2 @@ | |||
| # api-gateway-verification | |||
| Shared library to verify | |||
| library for api gateway verification | |||
There was a problem hiding this comment.
Please could we add some notes on how the library should be used? First from how does this dependency get added into your pom.xml and second from where does it get included in my code.
|
|
||
|
|
||
| @ExtendWith(SpringExtension.class) | ||
| public class HTTPRequestSignatureVerificationEnabledHandlerTest { |
There was a problem hiding this comment.
What did we have to change to the implementation class in bringing it here? As the handler isn't here I can't easily tell.
|
|
||
| on: | ||
| push: | ||
| branches: [ master, develop , ft* ] |
There was a problem hiding this comment.
On reflection I think we probably want to save minutes and not build feature branches by default? I assume GitHub workflows have similar restrictions to Azure DevOps?
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information