PERSON SAYAO REACT PROP ??#3739
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation requires changes before approval. There are critical issues causing test failures that directly block task completion.
Critical Issues (Must Fix)
-
Incorrect name output format: Your component renders
Mishabut tests expectMy name is Misha. Update the name template to include the full sentence. -
Incorrect age output format: Your component renders
Age: 37but tests expectI am 37. Adjust the age template to match the expected format.
Minor Improvement (Recommended)
- Checklist Item #3: Extract the nested ternary
sex === 'm' ? 'wife' : 'husband'into a separate variable (e.g.,partnerRole) before using it in the template literal. This improves readability and follows the style guide.
Summary
Your code structure and logic are solid—destructuring is correct, conditional rendering works, and the partner relationship logic is implemented properly. The main blocker is that the text output doesn't match the exact format expected by the tests. Update the template literals to include the full descriptive text, and your solution should pass all tests.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| const partnerPhrase = isMarried | ||
| ? `${partnerName} is my ${sex === 'm' ? 'wife' : 'husband'}` |
There was a problem hiding this comment.
This violates checklist item #3: avoid putting several cases to conditional rendering. Create separate variable for the condition. The nested ternary sex === 'm' ? 'wife' : 'husband' should be extracted to a separate variable (e.g., partnerRole) before using it in the template literal.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
IanLuan
left a comment
IanLuan
left a comment
There was a problem hiding this comment.
The DEMO LINK is not working. Please run npm run deploy.
Also, apply the changes requested by the AI mentor so your tests can pass.
|
DEMO LINK |
|
DEMO LINK.github.io/react_person/) |
raulriato
left a comment
raulriato
left a comment
There was a problem hiding this comment.
Your DEMO LINK is still not working. You should make sure the deploy was successfull before re-requesting review.
If you need help, feel free to contact the mentors in the questions chat
4 participants
No description provided.