Skip to content

⚡ Bolt: Replace fmt.Sprintf with string concatenation in workstore queries #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matdev83 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −9
Open

⚡ Bolt: Replace fmt.Sprintf with string concatenation in workstore queries #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/infra/terminalwork/workstore/durable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ func (s *DurableStore) claimDueSQLite(ctx context.Context, cmd ClaimDueCommand,
where = append(where, "kind = ?")
args = append(args, string(cmd.Kind))
}
query := fmt.Sprintf(`SELECT * FROM economic_terminal_work WHERE %s ORDER BY created_at_unix ASC, work_id ASC`, strings.Join(where, " AND "))
query := "SELECT * FROM economic_terminal_work WHERE " + strings.Join(where, " AND ") + " ORDER BY created_at_unix ASC, work_id ASC"
var candidates []workRow
if err := tx.NewRaw(query, args...).Scan(ctx, &candidates); err != nil {
return nil, err
Expand Down
10 changes: 2 additions & 8 deletions internal/infra/terminalwork/workstore/query_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package workstore

import (
"fmt"
"strings"
)

Expand All @@ -27,7 +26,7 @@ func buildListQuery(storeID string, q Query, limit, offset int) (string, []any)
placeholders = append(placeholders, "?")
args = append(args, string(st))
}
where = append(where, fmt.Sprintf("state IN (%s)", strings.Join(placeholders, ",")))
where = append(where, "state IN ("+strings.Join(placeholders, ",")+")")
}
if provider := strings.TrimSpace(q.ProviderID); provider != "" {
where = append(where, "provider_id = ?")
Expand Down Expand Up @@ -63,12 +62,7 @@ func buildListQuery(storeID string, q Query, limit, offset int) (string, []any)
args = append(args, q.UpdatedBefore.UTC().UnixNano())
}

query := fmt.Sprintf(`
SELECT * FROM economic_terminal_work
WHERE %s
ORDER BY created_at_unix ASC, work_id ASC
LIMIT ? OFFSET ?
`, strings.Join(where, " AND "))
query := "SELECT * FROM economic_terminal_work WHERE " + strings.Join(where, " AND ") + " ORDER BY created_at_unix ASC, work_id ASC LIMIT ? OFFSET ?"
args = append(args, limit, offset)
return query, args
}