Feature/sof 8034 - #296
Draft
VsevolodX wants to merge 3 commits into
Draft
Conversation
The VITE_* lookup only resolves where vite injects it. Consumers that bundle this package -- web-app via rspack -- got undefined and silently fell back to the default JupyterLite, so the Transformation dialog ran stale notebooks against the released `made`. Hardcode the origin so every consumer agrees. TEMPORARY. Restore the VITE_* lookup once made#297 and api-examples#361 merge. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Triggers release-wip.yml so web-app can consume this branch's build -- which hardcodes the SOF-8034 JupyterLite origin -- instead of relying on a DefinePlugin workaround in web-app's own bundler config.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for mat3ra-materials-designer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.