fix(SOF-8040): treat jobId as an optional filter when locating unit properties - #11
Open
VsevolodX wants to merge 2 commits into
Open
fix(SOF-8040): treat jobId as an optional filter when locating unit properties#11VsevolodX wants to merge 2 commits into
VsevolodX wants to merge 2 commits into
Conversation
VsevolodX
force-pushed
the
feature/SOF-8040
branch
from
August 29, 2026 01:57
7787fa2 to
0800370
Compare
…lease] @mat3ra/ide, @mat3ra/made and @mat3ra/mode were pinned to wip release tarballs that cleanup-wip-releases.yml has since deleted, so `npm install` 404s and CI cannot reach the test step on any branch, main included. None of the three is imported by ave's source. Repinned to the latest published versions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ExecutionUnitViewer is rendered through @mat3ra/workflow-designer and @mat3ra/wove, neither of which passes jobId, so the ternary always took the undefined branch and both tabs rendered without an href. The matched property carries the job id, so the parameter is only a filter. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
VsevolodX
force-pushed
the
feature/SOF-8040
branch
from
September 1, 2026 03:04
0800370 to
493f156
Compare
| return jobProperties.find((p) => { | ||
| return ( | ||
| p.source.info.jobId === ctx.jobId && | ||
| (!ctx.jobId || p.source.info.jobId === ctx.jobId) && |
Member
There was a problem hiding this comment.
Can we remove handling jobId here and just pass the notebookURL directly? The job logic should be in jode, jove, job-designer - one of those
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOF-8040 — one of four PRs; see the others in
rupy,web-app,standata.ExecutionUnitVieweris rendered by@mat3ra/workflow-designerthrough@mat3ra/wove, and neither forwards ajobId. Both property lookups required one, so in the webapp it was alwaysundefined:<a target="_blank">with no href, so clicking them did nothinggetMonitorsFromPropertiesreturned[]for every unit, which also removed the convergence Charts tabConfirmed by reading the live React fiber props on a running job:
{unitStatus:"active", unitRep:0, execName:"jupyter", propsCount:1}withjobIdabsent, and the matching property present injobProperties.Callers already fetch
jobPropertiesfor a single job and unit flowchart ids are unique within one, sojobIdonly ever narrowed. It stays as the first parameter, now optional, and the job id is taken from the matched property when absent — so no call site reorders and the existing tests are untouched.Verified: 21/21 tests pass (20 existing + 1 new), and the fixed resolver returns both URLs when fed the real property document from Mongo with
jobIdundefined. Not seen rendering in a browser.Note:
npm installfails onmain—package.json:54pins@mat3ra/modeto awip-tarball that 404s — so CI cannot reach the test step here. Pre-existing and unrelated to this change.🤖 Generated with Claude Code