Fix query builder expressions#22
Open
circulon wants to merge 4 commits into
Open
Conversation
- Added a helper to make splitting “as alias” clauses simple - fixed FromExpression not handing alias properly - removed redundant alias parameter from AggregateExpression and added a deprecation warning - added raw param to from_ method - removed redundant process_table() method from MySqlGrammar
fixed and added tests using alias and order by renamed postgres grammar test files to match other grammars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses several issues:
example:
Issues addressed
aliasparameter from AggregateExpression as its now handled correctly by the column helperrawparameter tofrom_to align with thetablemethodaggragate()about not using thealiasparameterprocess_table()fromMySqlGrammarraw=Truecan be used