Skip to content

FAT: pass changed analog Value 1 / Value 2 pairs - #248

Draft
masarray wants to merge 6 commits into
mainfrom
fix/fat-analog-assessment-pass
Draft

FAT: pass changed analog Value 1 / Value 2 pairs#248
masarray wants to merge 6 commits into
mainfrom
fix/fat-analog-assessment-pass

Conversation

@masarray

@masarray masarray commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Contract

FAT current-pair assessment now follows the operator contract consistently:

  • discrete: any authoritative good-quality state change in the current V1/V2 pair passes (FALSE -> TRUE, TRUE -> FALSE, OPEN -> CLOSED, CLOSED -> OPEN)
  • analog: stable good-quality V1/V2 passes when the numeric value changes beyond the same adaptive settling tolerance used by auto-capture
  • same/noise-level analog values remain non-passing and require review / further change

Implementation

  • preserves existing generation, sequence, quality and stale-evidence guards
  • routes analog current evidence through numeric-change assessment instead of discrete state normalization
  • analog rows now render PASS / REVIEW / FAIL from the current assessment rather than generic COMPLETE
  • leaves non-analog operator-snapshot semantics unchanged
  • does not change IEC acquisition cadence, reconnect logic, journal ordering, or analog auto-capture settling

Regression coverage

  • discrete false/true in both directions
  • SCL-style Open/Closed in both directions
  • changed analog V1/V2 -> PASS
  • analog difference inside settling tolerance -> REVIEW / no false PASS
  • bad-quality analog pair -> REVIEW
  • end-to-end stable analog auto-capture 0 -> 65.748 -> current-pair PASS
  • noise within tolerance does not auto-create V2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant