Conversation
Move icon path resolution into the Icon component so callers pass bare filenames (e.g. "chevron-down.svg") instead of building full paths with config.iconPath. Relative src values are prefixed with config.iconPath; absolute and protocol-relative URLs are used as-is. Change the default iconPath from /icons to the Lucide GitHub CDN, removing the postinstall copy step and bundled icon files.
Redesigns the contextual menu component as ActionMenu with support for nested submenus, hotkeys, and a cleaner API using typed ActionGroup/Action instead of the previous ContextualMenuProps.
Replace `props.X` template references with direct prop access and consolidate inline fallbacks into `withDefaults`. Also disable `vue/require-default-prop` ESLint rule to align with the new pattern.
Remove type, placeholder, autocomplete from InputProps and replace explicit event re-emits with $attrs passthrough. class and style are intercepted and merged into the container; all remaining attrs (including event listeners and native input attributes) flow through to the inner <input>. Stories updated with an InputStoryArgs type to document native attrs in a separate category.
✅ Deploy Preview for bocins ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
It establishes a layout boundary so the Picker's internal content doesn't affect the parent's layout calculations.
No needed to click anchor to display the content. This is specially useful on anchors that have native click events.
Prevents interference with parent --translate like in Modal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActionMenu(replacesContextualMenu),Progress,Slider,PullToAccordionremoved;ContextualMenuremoved;Calendarprops renamed (invalid→excluded,valid→allowed);Buttonvariant/size refactored to boolean flags;Modalusesv-model:open;Chipcloseevent renamed toaction;Togglerradiobool replaced bygroupnameopen/closemethods exposedTabViewtransitions with directional awarenessis-block,is-panel,is-input, etc.),focus-visiblereplacesfocusinteractionsTreeListandDatePickerIcon.vuewith Lucide CDN as default; local icon bundle removeduse-bocins-uiskill with overlay patterns and component guidesTest plan
npm run devand verify all Storybook stories render correctlyActionMenu,Progress,Slider,PullToDropdown/Popoveropen/close with all 16 positionsTabsanimated transitions (forward/backward direction)TreeListandDatePickerCalendarexcluded/allowedprops work correctlyModalv-model:openbindingnpm run lintand confirm no errorsnpm run buildand confirm dist output is clean