Skip to content

fix(app): preserve local links when moving notes#558

Merged
murongg merged 3 commits into
mainfrom
fix/issue-556-asset-links
Jul 19, 2026
Merged

fix(app): preserve local links when moving notes#558
murongg merged 3 commits into
mainfrom
fix/issue-556-asset-links

Conversation

@murongg

@murongg murongg commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • preserve relative image, attachment, and document link targets when a Markdown file moves between folders
  • rebase the latest moved file from disk, while keeping an open unsaved draft isolated and dirty
  • preserve self references and query-only links, and apply link edits in one linear pass for large notes
  • restore the original file location when moved content cannot be read or rewritten

Validation

  • pnpm test — 2,437 tests passed across the workspace
  • pnpm --filter @markra/app typecheck:test — passed
  • pnpm --filter @markra/markdown typecheck:test — passed
  • pnpm build — workspace, desktop, and web builds passed

Risk

  • moving a whole folder keeps its existing behavior because internal relative paths move with the folder; this PR only rebases individually moved Markdown files
  • remote URLs, anchors, root paths, fenced code, self references, and query-only links are left unchanged
  • ordinary tree moves no longer save unrelated dirty tabs; AI workspace plans retain their existing explicit pre-save behavior

Related Issues

Closes #556

@vercel

vercel Bot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jul 19, 2026 3:12am

@murongg
murongg merged commit 26bf651 into main Jul 19, 2026
21 checks passed
@murongg
murongg deleted the fix/issue-556-asset-links branch July 19, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Editor]: Bug ? Move notes bettween folders does not "move" image/atachements "with" it

1 participant