fix(ai): include client version in ACP initialization#553
Merged
Conversation
ACP 0.23 agents require clientInfo.version during negotiation. Refs #544
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Kimi Code 0.26.0 uses ACP SDK 0.23.0, which requires
clientInfo.version. Markra omitted that field, so Kimi rejected the firstinitializerequest with-32602 Invalid params.Validation
pnpm --filter @markra/app exec vitest run src/lib/acp-agent.test.ts— 18 passedpnpm --filter @markra/ai test— 245 passedpnpm --filter @markra/app typecheck:test— passedpnpm --filter @markra/app build— passedpnpm --filter @markra/ai build— passedpnpm --filter @markra/desktop build— passed, including vendor chunk verificationKnown test issue
pnpm --filter @markra/app testcompleted 1,836 of 1,837 tests successfully. The existingApp.ai.test.tsxvisible-editor test failed and was reproduced in the unmodified original worktree, so it is unrelated to this change.Fixes #544