Skip to content

fix(ai): include client version in ACP initialization#553

Merged
murongg merged 1 commit into
mainfrom
fix/issue-544-kimi-acp-version
Jul 17, 2026
Merged

fix(ai): include client version in ACP initialization#553
murongg merged 1 commit into
mainfrom
fix/issue-544-kimi-acp-version

Conversation

@murongg

@murongg murongg commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • require ACP client metadata to include a version
  • send the Markra app version for document and inline ACP sessions
  • add a regression test for the initialization payload

Why

Kimi Code 0.26.0 uses ACP SDK 0.23.0, which requires clientInfo.version. Markra omitted that field, so Kimi rejected the first initialize request with -32602 Invalid params.

Validation

  • pnpm --filter @markra/app exec vitest run src/lib/acp-agent.test.ts — 18 passed
  • pnpm --filter @markra/ai test — 245 passed
  • pnpm --filter @markra/app typecheck:test — passed
  • pnpm --filter @markra/app build — passed
  • pnpm --filter @markra/ai build — passed
  • pnpm --filter @markra/desktop build — passed, including vendor chunk verification

Known test issue

  • pnpm --filter @markra/app test completed 1,836 of 1,837 tests successfully. The existing App.ai.test.tsx visible-editor test failed and was reproduced in the unmodified original worktree, so it is unrelated to this change.

Fixes #544

ACP 0.23 agents require clientInfo.version during negotiation.

Refs #544
@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jul 17, 2026 11:17am

@murongg
murongg merged commit bcbff80 into main Jul 17, 2026
21 checks passed
@murongg
murongg deleted the fix/issue-544-kimi-acp-version branch July 17, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AI]: 怎么使用kimi code acp呢

1 participant