fix(export): improve numeral rendering in exported documents#552
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
murongg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PDF exports use browser-generated HTML. The previous font stack rendered Latin numerals with
ui-serifor Georgia while Chinese text fell back to a separate CJK font, leaving mixed-script text visually inconsistent even after enabling lining figures.Validation
pnpm --filter @markra/app test— 122 test files and 1832 tests passed.pnpm --filter @markra/app build— TypeScript build check passed.pdftoppm; verified consistent date numerals and mixed Han/numeral text with no clipping or layout regression.Risk
Low. This is export-only CSS. Simplified Chinese exports now use the first available CJK serif family for Latin text and numerals as well as Han text; other language exports and the Pandoc path are unchanged.
Closes #551