fix(editor): render paired inline HTML tags#550
Merged
Conversation
Render balanced inline HTML through view decorations so nested Markdown remains editable and source serialization stays unchanged. Reuse the existing raw HTML sanitizer for inline attributes. Closes #543
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<sup>...</sup>as real inline elements in the visual editorWhy
Milkdown represents inline raw HTML as separate opening and closing atoms. Rendering each atom independently made opening tags disappear and closing tags fall back to visible source.
The Markdown stringifier also normalizes a soft break immediately before an HTML node into a space. In split mode, the deferred visual update then wrote that normalized line back to the source pane. This PR marks single-line HTML tokens only while stringifying so their original line breaks survive without changing the ProseMirror document.
Validation
pnpm testpassed: 2,412 testspnpm buildpassed, including desktop vendor chunk verificationpnpm --filter @markra/app typecheck:testpassedRisk
Note
 is the Markdown serializer preserving a trailing space and reproduces without HTML. This PR does not strip it because doing so would make source round-trips lossy.Closes #543