feat(desktop): add adaptive macOS app icon#523
Open
murongg wants to merge 1 commit into
Open
Conversation
Compile the Icon Composer source during macOS builds and bundle its asset catalog alongside the legacy icon fallback. Use macOS 26 release runners so both architectures build with Xcode 26.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Assets.carduring macOS Tauri builds while retaining the legacy.icnsfallbackWhy
macOS 26 can select the matching light or dark app icon for Finder, Dock, Launchpad, and desktop aliases even when Markra is not running. This uses the native icon asset system instead of runtime icon switching.
Validation
pnpm testpassed (2,332 tests)pnpm buildpassedcargo test --manifest-path apps/desktop/src-tauri/Cargo.toml --lockedpassed (234 tests)pnpm tauri build --debugproduced the macOS app and DMG bundlesxcrun assetutil --validate-fileaccepted the bundled asset catalogRisk
.icnsfallback