Skip to content

feat(desktop): add adaptive macOS app icon#523

Open
murongg wants to merge 1 commit into
mainfrom
feature/macos-adaptive-icon
Open

feat(desktop): add adaptive macOS app icon#523
murongg wants to merge 1 commit into
mainfrom
feature/macos-adaptive-icon

Conversation

@murongg

@murongg murongg commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add an Icon Composer source with appearance-specific Markra foreground colors and a native system background
  • compile and bundle Assets.car during macOS Tauri builds while retaining the legacy .icns fallback
  • move Apple Silicon and Intel release jobs to macOS 26 runners with Xcode 26

Why

macOS 26 can select the matching light or dark app icon for Finder, Dock, Launchpad, and desktop aliases even when Markra is not running. This uses the native icon asset system instead of runtime icon switching.

Validation

  • pnpm test passed (2,332 tests)
  • pnpm build passed
  • cargo test --manifest-path apps/desktop/src-tauri/Cargo.toml --locked passed (234 tests)
  • pnpm tauri build --debug produced the macOS app and DMG bundles
  • xcrun assetutil --validate-file accepted the bundled asset catalog
  • macOS IconServices rendered distinct default and dark outputs without launching Markra

Risk

  • macOS packaging now requires Xcode 26 or later; release jobs use the corresponding GitHub-hosted runners
  • older macOS versions continue to use the existing .icns fallback
  • non-macOS icon build invocations remain no-ops

Compile the Icon Composer source during macOS builds and bundle its asset catalog alongside the legacy icon fallback. Use macOS 26 release runners so both architectures build with Xcode 26.
@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jul 13, 2026 12:27am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant