Compatibility and feature enhancements#258
Open
CooperGerman wants to merge 16 commits into
Open
Conversation
…E_CALIBRATE suite.
…ne z_offset handling
…ce probe point handling
…ternal endstop handling
…probe use according to overriden tilt and sgl setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
first of all I'd like to thank you for all the work you put into this amazing project.
As I installed and tried it out I was unfortunately stuck on some aspects and wanted to share my fixes and upgrades if you are interested:
Features and fixes
homing_probe_z_offsetinstead ofz_offsetbecause of changes above.console_verbosityparameters (defaults to0for cleaner console), and restores previous logging starting at1.Disclosure:
I use Copilot as my coding assistant, but I reviewed changes myself and I understand klipper reasonably well as I have often modified it or developed plugins and am Happy Hare project contributor.
I would be more than happy to dicuss some this PR with you if you want. You can contact me either through discord
@coopergermanor by email yannick.leprovost@uboe.fr.Limitations :
I cannot test and account for all klipper variations and sensors configurations and i would strongly suggest this PR got merged into a dev branch to be beta tested if anybody is willing to do so.
Side Note : We would like to equip all of our printers with this solution and are facing a little issue, do you think it might be possible to have longer (antenna) cables for the sensor ? Our largest printer is 600x600x200 and the current one is not long enough to place the pcb outside of the chamber (feel free to contact us at contact@uboe.fr).