Add decoder for CMD 0x0F chlorinator pump mode unicast (issue #23)#54
Merged
Conversation
…ch#23) Handles the Viron Chlorinator (0x0084) → Touchscreen (0x0050) unicast that sets current pump mode. Log-only; no pool_state update since the pump announces its own speed independently.
Owner
|
This looks great, but has me wondering if the same command could also be sent from the internet gateway. Still away so can't test, but if it works then it could make this command more generic. Happy to merge as is though and can revisit this theory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles the Viron Chlorinator (0x0084) → Touchscreen (0x0050) unicast that sets current pump mode. Log-only; no pool_state update since the pump announces its own speed independently.
Based on the report in issue #23.