Skip to content

Fix DOM-based XSS on home page pool table #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marklynch merged 2 commits into from
Jun 25, 2026
Merged

Fix DOM-based XSS on home page pool table #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa3cc49
Fix DOM-based XSS on home page pool table
claude Jun 25, 2026
b3b0a6f
Add changelog entry for home page XSS fix
claude Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
### Deprecated
### Security
- Fixed a DOM-based XSS on the home page: channel/zone/valve names read from the bus were injected into the pool status table via `innerHTML`. They are now set with `textContent` so bus-derived strings can never be parsed as HTML/script.

## [1.6.0] - 2026-06-16
### Changed
Expand Down
4 changes: 3 additions & 1 deletion main/web_handlers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,9 @@ static esp_err_t home_get_handler(httpd_req_t *req)
"const tb=document.getElementById('pool-body');"
"rows.forEach(([k,v])=>{"
"const tr=document.createElement('tr');"
"tr.innerHTML='<th>'+k+'</th><td>'+v+'</td>';"
"const th=document.createElement('th');th.textContent=k;"
"const td=document.createElement('td');td.textContent=v;"
"tr.appendChild(th);tr.appendChild(td);"
"tb.appendChild(tr);});"
"document.getElementById('pool-loading').hidden=true;"
"document.getElementById('pool-table').removeAttribute('hidden');"
Expand Down