MLE-30244 move Jenkins registry credentials to the publish stage and …#1951
Merged
RitaChen609 merged 4 commits intoJun 26, 2026
Merged
Conversation
…validate the MARKLOGIC_IMAGE_TAGS build parameter
There was a problem hiding this comment.
Pull request overview
Updates the Jenkins pipeline for the MarkLogic Java client API build to (a) scope publishing credentials to the publish stage instead of global environment variables and (b) validate the MARKLOGIC_IMAGE_TAGS parameter to reduce the risk of user-supplied tag values altering shell/Docker command behavior.
Changes:
- Moved registry/publish credentials from global
environment {}to awithCredentialsblock in thepublishstage. - Added validation for
MARKLOGIC_IMAGE_TAGSbefore using it to construct Docker image references in theregressionsstage.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
Jenkinsfile:245
imageTagsis already trimmed via.collect { it.trim() }, but the loop trims eachtagagain. This is redundant and slightly obscures the intent; use the already-trimmedtagdirectly (or trim once per iteration, but not both).
imageTags.each { tag ->
def fullImage = imagePrefix + tag.trim()
def stageName = "regressions-${tag.trim().replace(':', '-')}"
jonmille
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…validate the MARKLOGIC_IMAGE_TAGS build parameter