[Eval] Robust CPU-based Efficient MATH grader - #95
Open
Nativeatom wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
penfever
requested changes
Aug 29, 2026
penfever
left a comment
Collaborator
There was a problem hiding this comment.
🤖 Requesting changes: the revised graders are not wired into shipped math benchmarks, which still import lm-eval graders. Integrate them into the intended task path, or narrow the PR to a non-production utility with accurate scope. Required code CI also has not run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL; DR
Extending the existing CPU-based MATH grader to more broader cases with larger testing samples (considering the string match nature of many libraries). Specifically
(1,2)=( 1, 2 ),1+2i=1 + 2 i.$1,000,000$,$1,\\!000\\!000$and$1000000$are identical.$.12$=$0.12$.$\frac{1}{2}$=$0.5$.$$2$$and$2$.\\text{Amy},$Amy$are equivalent toAmy.\\dfracand\\tfracshould be reduced and equivalent to\\frac.\\left[ X, Y \\right],\\left(X, Y\\right)should be reduced to[X, Y]and(X, Y)respectively. Besides, it also obey the previous white-space insensitivity:\\left( X, Y \\right)is equivalent to(X, Y).$E$,(E),$(E)$,\\text{E},\\text{(E)}should be reduced and equivalent toEafter extraction.$40$is correct if the reference isPerformance
The missing agreement is due to evaluating answers with multiple values, see
NotesNotes
(a+2)(b+1)and(b+1)(a+2).parse_latexdesign ofsympy, the ANTLR parser parses the first valid sub-expression and silently ignores the trailing input. The grammar has no top-level comma production. And the remaining answer would be dropped.Testing
New testing script in
Part of marin-community/marin#7463, extended from #58.