chore: retains apiversion in app description and app deployments#189
chore: retains apiversion in app description and app deployments#189vireshnavalli wants to merge 2 commits into
Conversation
Signed-off-by: vireshnavalli <viresh-r.navalli@capgemini.com>
Signed-off-by: vireshnavalli <viresh-r.navalli@capgemini.com>
nilanjan-samajdar
left a comment
nilanjan-samajdar
left a comment
There was a problem hiding this comment.
The apiVersion should be v1.0.0-rc.2
Corresponding to the recently release spec version v1.0.0-rc.2
| # Demonstrates validation of kind field | ||
| # Invalid kind of Kubernetes custom resource. | ||
| apiVersion: margo.org/v1-alpha1 | ||
| apiVersion: 1.0.0 |
There was a problem hiding this comment.
Should be v1.0.0-rc.2
Corresponding to v1.0.0-rc.2
| # Demonstrates validation of id field | ||
| # Invalid id format being defined in this test | ||
| apiVersion: margo.org/v1-alpha1 | ||
| apiVersion: 1.0.0 |
There was a problem hiding this comment.
Should be v1.0.0-rc.2
Corresponding to v1.0.0-rc.2
| @@ -1,4 +1,4 @@ | |||
| apiVersion: margo.org/v1-alpha1 | |||
| apiVersion: 1.0.0 | |||
There was a problem hiding this comment.
Should be v1.0.0-rc.2
Corresponding to v1.0.0-rc.2
| @@ -1,4 +1,4 @@ | |||
| apiVersion: margo.org/v1-alpha1 | |||
| apiVersion: 1.0.0 | |||
There was a problem hiding this comment.
Should be v1.0.0-rc.2
Corresponding to v1.0.0-rc.2
| # Demonstrates validation of kind field | ||
| # Invalid kind of Kubernetes custom resource. | ||
| apiVersion: application.margo.org/v1alpha1 | ||
| apiVersion: 1.0.0 |
There was a problem hiding this comment.
Should be v1.0.0-rc.2
Corresponding to v1.0.0-rc.2
| @@ -1,4 +1,4 @@ | |||
| apiVersion: application.margo.org/v1alpha1 | |||
| apiVersion: 1.0.0 | |||
There was a problem hiding this comment.
Should be v1.0.0-rc.2
Corresponding to v1.0.0-rc.2
| @@ -1,4 +1,4 @@ | |||
| apiVersion: application.margo.org/v1alpha1 | |||
| apiVersion: 1.0.0 | |||
There was a problem hiding this comment.
Should be v1.0.0-rc.2
Corresponding to v1.0.0-rc.2
| @@ -1,4 +1,4 @@ | |||
| apiVersion: application.margo.org/v1alpha1 | |||
| apiVersion: 1.0.0 | |||
There was a problem hiding this comment.
Should be v1.0.0-rc.2
Corresponding to v1.0.0-rc.2
| @@ -1,4 +1,4 @@ | |||
| apiVersion: application.margo.org/v1alpha1 | |||
| apiVersion: 1.0.0 | |||
There was a problem hiding this comment.
Should be v1.0.0-rc.2
Corresponding to v1.0.0-rc.2
|
|
||
| ```yaml | ||
| apiVersion: application.margo.org/v1alpha1 | ||
| apiVersion: 1.0.0 |
There was a problem hiding this comment.
Should be v1.0.0-rc.2
Corresponding to v1.0.0-rc.2
|
Since |
Yes, @vireshnavalli please close this PR and recreate as a SUP within the specification enhancements repository.
@jachstet-sea: This PR will be closed so changs will not be implemented prior to plugfest. As for the API definition that will be the baseline for Plugfest testing, the current version is I'll let the newly created SUP work out the API versioning strategy. |
5 participants
Description
As the API routes include version within URL there is not need to explicitly have 'apiVersion' attribute for margo specified REST apis . Keeping the apiVersion in ApplicationDescription and ApplicationDeployment, although the version string needs to be the same as the OpenAPI version and follow semantic versioning.
Issues Addressed
Address #134
Change Type
Please select the relevant options:
Checklist