Fix excel upload and tests - #2
Merged
Merged
Conversation
pandas.read_excel() needs xlrd to read legacy .xls files (openpyxl only covers .xlsx/.xlsm), but xlrd was never in requirements.txt, so uploading a .xls dataset 500s at the column-mapping step with "ImportError: Import xlrd failed". No application code change is needed once the dependency is present. Adds a regression-test suite built from a 10-row extract of the first sheet of a real Isotrace .xls file: fixtures in the same three formats accepted by the upload wizard (.csv/.xlsx/.xls), unit tests on services.load_dataframe(), and an end-to-end test driving the actual upload -> map columns -> preview -> import views for each format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.